linux-kernel - Re: [PATCH 1/1] usb: usleep_range is preferred over udelay where wakeup is flexible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Jun 2015 21:15:03 +0530
From:	Sunny Kumar <sunny.kumar.roy@...il.com>
To:	mdharm-usb@...-eyed-alien.net, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: usleep_range is preferred over udelay where
 wakeup is flexible

Ok then,
This might be the final lower and upper limit value.

Sunny Kumar

On Wed, Jun 24, 2015 at 12:24:29PM +0530, Sunny Kumar wrote:
> According to Documentation/timers/timers-howto.txt"
> udelay() is only called once from a place where sleeping is allowed.
> We can replace it with a call to usleep_range()
> with a reasonable upper limit.
> 
> Signed-off-by: Sunny Kumar <sunny.kumar.roy@...il.com>
> ---
>  drivers/usb/storage/transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c
> index 540add2..7cd45ac 100644
> --- a/drivers/usb/storage/transport.c
> +++ b/drivers/usb/storage/transport.c
> @@ -1111,7 +1111,7 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us)
>  	 * command phase and the data phase.  Some devices need a little
>  	 * more than that, probably because of clock rate inaccuracies. */
>  	if (unlikely(us->fflags & US_FL_GO_SLOW))
> -		udelay(125);
> +		usleep_range(100, 125);
>  
>  	if (transfer_length) {
>  		unsigned int pipe = srb->sc_data_direction == DMA_FROM_DEVICE ? 
> -- 
> 2.1.4
> 

View attachment "0001-usb-usleep_range-is-preferred-over-udelay-where-wake.patch" of type "text/x-diff" (1203 bytes)