linux-kernel - Re: [PATCH] keys: Delete an unnecessary check before the function call "key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150625131244.GA25232@mail.hallyn.com>
Date:	Thu, 25 Jun 2015 08:12:44 -0500
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	David Howells <dhowells@...hat.com>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>, keyrings@...ux-nfs.org,
	linux-security-module@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] keys: Delete an unnecessary check before the function
 call "key_put"

On Wed, Jun 24, 2015 at 03:20:47PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 24 Jun 2015 15:16:35 +0200
> 
> The key_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Serge Hallyn <serge.hallyn@...onical.com>

> ---
>  security/keys/process_keys.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
> index bd536cb..225dd08 100644
> --- a/security/keys/process_keys.c
> +++ b/security/keys/process_keys.c
> @@ -242,9 +242,7 @@ int install_session_keyring_to_cred(struct cred *cred, struct key *keyring)
>  	old = cred->session_keyring;
>  	rcu_assign_pointer(cred->session_keyring, keyring);
>  
> -	if (old)
> -		key_put(old);
> -
> +	key_put(old);
>  	return 0;
>  }
>  
> -- 
> 2.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/