linux-kernel - Re: [PATCH] sysfs: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150625131326.GB25232@mail.hallyn.com>
Date:	Thu, 25 Jun 2015 08:13:26 -0500
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>, kbuild-all@...org,
	Casey Schaufler <casey@...aufler-ca.com>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysfs: fix simple_return.cocci warnings

On Wed, Jun 24, 2015 at 07:41:07AM +0800, kbuild test robot wrote:
> security/smack/smackfs.c:2251:1-4: WARNING: end returns can be simpified and declaration on line 2250 can be dropped
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> 
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Acked-by: Serge Hallyn <serge.hallyn@...onical.com>

> ---
> 
>  smackfs.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -2247,11 +2247,7 @@ static const struct file_operations smk_
>   */
>  static int smk_init_sysfs(void)
>  {
> -	int err;
> -	err = sysfs_create_mount_point(fs_kobj, "smackfs");
> -	if (err)
> -		return err;
> -	return 0;
> +	return sysfs_create_mount_point(fs_kobj, "smackfs");
>  }
>  
>  /**
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/