lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150625151800.GC6844@leverpostej>
Date:	Thu, 25 Jun 2015 16:18:00 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>
Cc:	"wsa@...-dreams.de" <wsa@...-dreams.de>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"michal.simek@...inx.com" <michal.simek@...inx.com>,
	"soren.brinkmann@...inx.com" <soren.brinkmann@...inx.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"punnaia@...inx.com" <punnaia@...inx.com>,
	"harinik@...inx.com" <harinik@...inx.com>,
	"anirudh@...inx.com" <anirudh@...inx.com>,
	"svemula@...inx.com" <svemula@...inx.com>,
	Anurag Kumar Vulisha <anuragku@...inx.com>
Subject: Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq
 Ultrascale+ MPSoC

On Thu, Jun 18, 2015 at 05:19:42PM +0100, Anurag Kumar Vulisha wrote:
> Removed the workarounds present in the cadence i2c driver for
> Zynq Ultrascale+ MPSoC

I guess this means that cdns,i2c-r1p10 had quirks fixed in
cdns,i2c-r1p14? It would be helpful to be a bit more explicit in the
commit message.

> 
> Signed-off-by: Anurag Kumar Vulisha <anuragku@...inx.com>
> ---
>  .../devicetree/bindings/i2c/i2c-cadence.txt        |    2 +-
>  drivers/i2c/busses/i2c-cadence.c                   |   67 ++++++++++++++++---
>  2 files changed, 57 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> index 7cb0b56..11ef7f2 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> @@ -2,7 +2,7 @@ Binding for the Cadence I2C controller
>  
>  Required properties:
>    - reg: Physical base address and size of the controller's register area.
> -  - compatible: Compatibility string. Must be 'cdns,i2c-r1p10'.
> +  - compatible: Compatibility string.Use 'cdns,i2c-r1p10' or 'cdns,i2c-r1p14'

Please format this as a list. It aids legibility and expansion. e.g:

- compatible: should contain one of:
  * "cdns,i2c-r1p10"
  * "cdns,i2c-r1p14"

Perhaps with notes as to the differences.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ