linux-kernel - Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150709200913.GL4744@katana>
Date:	Thu, 9 Jul 2015 22:09:13 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	punnaia@...inx.com, harinik@...inx.com, anirudh@...inx.com,
	svemula@...inx.com, Anurag Kumar Vulisha <anuragku@...inx.com>
Subject: Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq
 Ultrascale+ MPSoC

Hi,

thanks for the submission!

> +#define CDNS_I2C_BROKEN_HOLD_BIT	0x00000001

BIT(0) maybe?

> +static const struct cdns_platform_data r1p10_i2c_def = {
> +				.quirks = CDNS_I2C_BROKEN_HOLD_BIT, };

Closing '}' should be on seperate line.

And what Mark said.

Other than that, looks okay I'd say.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)