linux-kernel - Re: [PATCH] mm: fix set pageblock migratetype when boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150626110424.GI26927@suse.de>
Date:	Fri, 26 Jun 2015 12:04:24 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Xishi Qiu <qiuxishi@...wei.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Johannes Weiner <hannes@...xchg.org>, iamjoonsoo.kim@....com,
	David Rientjes <rientjes@...gle.com>, sasha.levin@...cle.com,
	Linux MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: fix set pageblock migratetype when boot

On Fri, Jun 26, 2015 at 06:09:05PM +0800, Xishi Qiu wrote:
> memmap_init_zone()
> 	...
> 	if ((z->zone_start_pfn <= pfn)
> 	    && (pfn < zone_end_pfn(z))
> 	    && !(pfn & (pageblock_nr_pages - 1)))
> 		set_pageblock_migratetype(page, MIGRATE_MOVABLE);
> 	...
> 
> If the pfn does not align to pageblock, it will not init the migratetype.

What important impact does that have? It should leave a partial pageblock
as MIGRATE_UNMOVABLE which is fine by me.

> So call it for every page, it will takes more time, but it doesn't matter, 
> this function will be called only in boot or hotadd memory.
> 

It's a lot of additional overhead to add to memory initialisation. It
would need to be for an excellent reason with no alternative solution.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/