linux-kernel - Re: [PATCH 0/3] mmc: sdhci: Card detection fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1435316756.32171.6.camel@linaro.org>
Date:	Fri, 26 Jun 2015 14:05:56 +0300
From:	"Ivan T. Ivanov" <ivan.ivanov@...aro.org>
To:	Jaehoon Chung <jh80.chung@...sung.com>
Cc:	Ulf Hansson <ulf.hansson@...aro.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Tim Kryger <tim.kryger@...il.com>,
	Aisheng Dong <b29396@...escale.com>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 0/3] mmc: sdhci: Card detection fixes


On Fri, 2015-06-26 at 19:31 +0900, Jaehoon Chung wrote:
> Hi, Ivan.
> 
> On 06/26/2015 07:00 PM, Ivan T. Ivanov wrote:
> > Following changes aimed to fix some aspects of card detection, when
> > BROKEN_CARD_DETECTION quirk is set.
> 
> As i know, when there is no card detection scheme, BROKEN_CARD_DETECTION quirks is set.
> If it can use CD_GPIO, doesn't it need to set BROKEN_CARD_DETECTION?
> Just wondering..
> 

I am not sure that I get this. My understanding is that if controller have 
issues reporting card present state, users could use GPIO for card state sensing.

Probably this don't sound reasonable, but someone could just want to ignore
controller capabilities and use GPIO explicitly.

Regards,
Ivan

> Best Regards,
> Jaehoon Chung
> 
> > Ivan T. Ivanov (3):
> >   mmc: sdhci: let GPIO based card detection have higher precedence
> >   mmc: sdhci: don't use card state polling when CD GPIO is defined
> >   mmc: sdhci: properly check card present state when quirk
> >     NO_CARD_NO_RESET is set
> > 
> >  drivers/mmc/host/sdhci.c | 17 ++++++++++-------
> >  1 file changed, 10 insertions(+), 7 deletions(-)
> > 
> > --
> > 1.9.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/