linux-kernel - Re: [PATCH 1/1] usb: storage : Remove c99 style commenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <558D46AF.2000609@cogentembedded.com>
Date:	Fri, 26 Jun 2015 15:33:51 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Sunny Kumar <sunny.kumar.roy@...il.com>,
	mdharm-usb@...-eyed-alien.net, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: storage : Remove c99 style commenting

Hello.

On 6/26/2015 9:14 AM, Sunny Kumar wrote:

> This patch fixes checkpatch.pl warning c99 style commenting.

> Signed-off-by: Sunny Kumar <sunny.kumar.roy@...il.com>
> ---
>   drivers/usb/storage/sddr55.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)

> diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
> index aacedef..54d0a59 100644
> --- a/drivers/usb/storage/sddr55.c
> +++ b/drivers/usb/storage/sddr55.c
> @@ -209,10 +209,10 @@ static int sddr55_read_data(struct us_data *us,
>   	unsigned int len, offset;
>   	struct scatterlist *sg;
>
> -	// Since we only read in one block at a time, we have to create
> -	// a bounce buffer and move the data a piece at a time between the
> -	// bounce buffer and the actual transfer buffer.
> -
> +	/* Since we only read in one block at a time, we have to create
> +	 * a bounce buffer and move the data a piece at a time between the
> +	 * bounce buffer and the actual transfer buffer.
> +	 */

    This style of commenting is preferred only in the networking code. The 
other parts of the kernel prefer this style:

/*
  * bla
  * bla
  */

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/