linux-kernel - Re: [PATCH 1/1] usb: storage : Remove c99 style commenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1506261003260.1566-100000@iolanthe.rowland.org>
Date:	Fri, 26 Jun 2015 10:08:42 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Sunny Kumar <sunny.kumar.roy@...il.com>
cc:	mdharm-usb@...-eyed-alien.net, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>,
	<usb-storage@...ts.one-eyed-alien.net>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] usb: storage : Remove c99 style commenting

On Fri, 26 Jun 2015, Sunny Kumar wrote:

> This patch fixes checkpatch.pl warning c99 style commenting.
> 
> Signed-off-by: Sunny Kumar <sunny.kumar.roy@...il.com>
> ---
>  drivers/usb/storage/sddr55.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
> index aacedef..54d0a59 100644
> --- a/drivers/usb/storage/sddr55.c
> +++ b/drivers/usb/storage/sddr55.c
> @@ -209,10 +209,10 @@ static int sddr55_read_data(struct us_data *us,
>  	unsigned int len, offset;
>  	struct scatterlist *sg;
>  
> -	// Since we only read in one block at a time, we have to create
> -	// a bounce buffer and move the data a piece at a time between the
> -	// bounce buffer and the actual transfer buffer.
> -
> +	/* Since we only read in one block at a time, we have to create
> +	 * a bounce buffer and move the data a piece at a time between the
> +	 * bounce buffer and the actual transfer buffer.
> +	 */
>  	len = min((unsigned int) sectors, (unsigned int) info->blocksize >>
>  			info->smallpageshift) * PAGESIZE;
>  	buffer = kmalloc(len, GFP_NOIO);
> @@ -336,10 +336,10 @@ static int sddr55_write_data(struct us_data *us,
>  		return USB_STOR_TRANSPORT_FAILED;
>  	}
>  
> -	// Since we only write one block at a time, we have to create
> -	// a bounce buffer and move the data a piece at a time between the
> -	// bounce buffer and the actual transfer buffer.
> -
> +	/* Since we only write one block at a time, we have to create
> +	 * a bounce buffer and move the data a piece at a time between the
> +	 * bounce buffer and the actual transfer buffer.
> +	 */
>  	len = min((unsigned int) sectors, (unsigned int) info->blocksize >>
>  			info->smallpageshift) * PAGESIZE;
>  	buffer = kmalloc(len, GFP_NOIO);

Why did you fix just these two sites?  There are lots of other places 
in usb-storage that use C99-style comments:

$ cd drivers/usb/storage
$ egrep '[^:]//' *.[ch] | wc
    177    1635    9562

(The [^:] is to avoid matching things like "http://", and as a result
this misses the four places where a // comment starts at the beginning
of a line.)

Why not fix all of them?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/