linux-kernel - Re: [PATCH] block: fix bogus EFAULT error from SG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49zj3mef2g.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 26 Jun 2015 10:09:59 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] block: fix bogus EFAULT error from SG_IO ioctl

Paolo Bonzini <pbonzini@...hat.com> writes:

> Whenever blk_fill_sghdr_rq fails, its errno code is ignored and changed to
> EFAULT.  This can cause very confusing errors:
>
>   $ sg_persist -k /dev/sda
>   persistent reservation in: pass through os error: Bad address
>
> The fix is trivial, just propagate the return value from
> blk_fill_sghdr_rq.
>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Acked-by: Jeff Moyer <jmoyer@...hat.com>

> ---
>  block/scsi_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> index 55b6f15dac90..dda653ce7b24 100644
> --- a/block/scsi_ioctl.c
> +++ b/block/scsi_ioctl.c
> @@ -326,8 +326,8 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk,
>  			goto out_put_request;
>  	}
>  
> -	ret = -EFAULT;
> -	if (blk_fill_sghdr_rq(q, rq, hdr, mode))
> +	ret = blk_fill_sghdr_rq(q, rq, hdr, mode);
> +	if (ret < 0)
>  		goto out_free_cdb;
>  
>  	ret = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/