linux-kernel - Re: [PATCH] block: fix bogus EFAULT error from SG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <558EE0D4.9070201@kernel.dk>
Date:	Sat, 27 Jun 2015 11:43:48 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: fix bogus EFAULT error from SG_IO ioctl

On 06/26/2015 03:44 AM, Paolo Bonzini wrote:
> Whenever blk_fill_sghdr_rq fails, its errno code is ignored and changed to
> EFAULT.  This can cause very confusing errors:
>
>    $ sg_persist -k /dev/sda
>    persistent reservation in: pass through os error: Bad address
>
> The fix is trivial, just propagate the return value from
> blk_fill_sghdr_rq.

Added, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/