linux-kernel - Re: DM_CACHE_SMQ is experimental and enabled by default? (was: Re: dm cache: add stochastic-multi-queue (smq) policy)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150626160549.GA15434@redhat.com>
Date:	Fri, 26 Jun 2015 12:05:50 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Joe Thornber <ejt@...hat.com>, linux-raid@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dm-devel@...hat.com
Subject: Re: DM_CACHE_SMQ is experimental and enabled by default? (was: Re:
 dm cache: add stochastic-multi-queue (smq) policy)

On Fri, Jun 26 2015 at  3:47am -0400,
Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> On Fri, Jun 26, 2015 at 2:13 AM, Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org> wrote:
> > Gitweb:     http://git.kernel.org/linus/;a=commit;h=66a636356647a9be8885c2ce2948de126577698a
> > Commit:     66a636356647a9be8885c2ce2948de126577698a
> > Parent:     40775257b97e27305cf5c2425be7acaa6edee4ea
> > Refname:    refs/heads/master
> > Author:     Joe Thornber <ejt@...hat.com>
> > AuthorDate: Fri May 15 15:33:34 2015 +0100
> > Committer:  Mike Snitzer <snitzer@...hat.com>
> > CommitDate: Thu Jun 11 17:12:59 2015 -0400
> >
> >     dm cache: add stochastic-multi-queue (smq) policy
> 
> > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> > index edcf4ab..b597273 100644
> > --- a/drivers/md/Kconfig
> > +++ b/drivers/md/Kconfig
> > @@ -304,6 +304,18 @@ config DM_CACHE_MQ
> >           This is meant to be a general purpose policy.  It prioritises
> >           reads over writes.
> >
> > +config DM_CACHE_SMQ
> > +       tristate "Stochastic MQ Cache Policy (EXPERIMENTAL)"
> > +       depends on DM_CACHE
> > +       default y
> 
> A feature cannot be "EXPERIMENTAL", and be enabled by default.
> Please drop (at least) one of them.

Thanks for your concern, but: no.

If you look closer the entirety of DM cache is marked EXPERIMENTAL:

config DM_CACHE
       tristate "Cache target (EXPERIMENTAL)"
...
config DM_CACHE_MQ
       tristate "MQ Cache Policy (EXPERIMENTAL)"
...
config DM_CACHE_SMQ
       tristate "Stochastic MQ Cache Policy (EXPERIMENTAL)"
...
config DM_CACHE_CLEANER
       tristate "Cleaner Cache Policy (EXPERIMENTAL)"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/