linux-kernel - Re: [PATCH 5/6] blkcg: move io_service_bytes and io_serviced stats into blkcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150626160923.GI15805@mtj.duckdns.org>
Date:	Fri, 26 Jun 2015 12:09:23 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, avanzini.arianna@...il.com,
	kernel-team@...com
Subject: Re: [PATCH 5/6] blkcg: move io_service_bytes and io_serviced stats
 into blkcg_gq

Hello, Vivek.

On Fri, Jun 26, 2015 at 12:01:42PM -0400, Vivek Goyal wrote:
> - Previously throttling policy was calculating number of IOs in terms of
>   number of bios while CFQ was calculating it in terms of number of
>   requests. I think this will be a behavior change now? IIUC, now even
>   throttling policy will report number of requests and number of bios.

Yes, it'd be.  I'll mention it in the description.  The thing is this
has never been documented or explained properly.  The only thing
userland saw would be the counts deviating over time.  I don't think
putting them on the same measure is gonna break anything.

> - Looks like completion and stat is now lined to request. I am wondering
>   what will happen to bio based targets. One can put a throttling policy
>   on any of the stacked dm devices. I suspect we will be broken there?

Dang, I forgot about bio based drivers.  I don't care whether it
counts bios or requests.  The only thing I want is counting the same
thing once instead of separately in subtly different ways.  I'll
converge them to bios.

> - Can you please also update the blkio-controller.txt. Specifically
>   blkio.throttle.io_serviced.

Sure, will do.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/