linux-kernel - [PATCH] staging:slicoss:slicoss.h remove volatile variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Jun 2015 12:57:32 -0700
From:	Vikul Gupta <guptav@...ux.vnet.ibm.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	"Cc: Lior Dotan" <liodot@...il.com>,
	Christopher Harrer <charrer@...critech.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging:slicoss:slicoss.h remove volatile variables

I am a high school student trying to become familiar with the opensource 
process and linux kernel. This is my first submission to the mailing list.

I fixed the slicoss sub-system. The TODO file asks to remove volatile 
variables - also, checkpatch.pl warnings included volatile variables.

I removed "volatile" from the variables /isr /and /linkstatus/ in the 
header file, because they are not needed. The two variables are used in 
the slicoss.c file, where /isr/ is used as function parameters, string 
outputs, pointers, logic, and one assignment, while /linkstatus /is used 
as pointers, logic, and one assignment. All but the assignments will not 
change these variables, and the assignment does not warrant a volatile 
qualifier.

To make sure the changes were correct, I ran the files with 
checkpatch.pl again, test built it, and rebooted it.

Signed-off-by: Vikul Gupta <guptav@...ux.vnet.ibm.com>

diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
index 3a5aa88..f19f86a 100644
--- a/drivers/staging/slicoss/slic.h
+++ b/drivers/staging/slicoss/slic.h
@@ -357,8 +357,8 @@ struct base_driver {
  };

  struct slic_shmem {
-    volatile u32          isr;
-    volatile u32          linkstatus;
+    u32          isr;
+    u32          linkstatus;
      volatile struct slic_stats     inicstats;
  };

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/