linux-kernel - Re: [PATCH] staging:slicoss:slicoss.h remove volatile variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Jun 2015 13:09:13 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Vikul Gupta <guptav@...ux.vnet.ibm.com>
Cc:	"Cc: Lior Dotan" <liodot@...il.com>,
	Christopher Harrer <charrer@...critech.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:slicoss:slicoss.h remove volatile variables

On Fri, Jun 26, 2015 at 12:57:32PM -0700, Vikul Gupta wrote:
> I am a high school student trying to become familiar with the opensource
> process and linux kernel. This is my first submission to the mailing list.

Great, but this paragraph doesn't belong in here, as this whole thing
will end up in the changelog body.  You can put any comments /
discussion below the --- line and it will not show up in the changelog
when I apply the patch.

> I fixed the slicoss sub-system.

The whole subsystem, nice?  :)

Seriously, this sentance is not needed.

> The TODO file asks to remove volatile
> variables - also, checkpatch.pl warnings included volatile variables.
> 
> I removed "volatile" from the variables /isr /and /linkstatus/ in the header

what's with the '/' usage?

> file, because they are not needed. The two variables are used in the
> slicoss.c file, where /isr/ is used as function parameters, string outputs,
> pointers, logic, and one assignment, while /linkstatus /is used as pointers,
> logic, and one assignment. All but the assignments will not change these
> variables, and the assignment does not warrant a volatile qualifier.
> 
> To make sure the changes were correct, I ran the files with checkpatch.pl
> again, test built it, and rebooted it.

can you test this code?  rebooting and not loading the driver isn't much
proof of much other than the code still builds (which is a good thing to
test.)  Also, this paragraph is not needed in the changelog either.

Care to fix this all up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/