linux-kernel - Re: [PATCH] block-rsxx: Deletion of an unnecessary check before the function call "vfree"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <558FDAC5.8020902@users.sourceforge.net>
Date:	Sun, 28 Jun 2015 13:30:13 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Joshua Morris <josh.h.morris@...ibm.com>,
	Philip Kelleher <pjk1939@...ux.vnet.ibm.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] block-rsxx: Deletion of an unnecessary check before the
 function call "vfree"

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 1 Dec 2014 19:19:25 +0100
> 
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/block/rsxx/dma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c
> index cf8cd29..0181387 100644
> --- a/drivers/block/rsxx/dma.c
> +++ b/drivers/block/rsxx/dma.c
> @@ -960,8 +960,7 @@ failed_dma_setup:
>  			ctrl->done_wq = NULL;
>  		}
>  
> -		if (ctrl->trackers)
> -			vfree(ctrl->trackers);
> +		vfree(ctrl->trackers);
>  
>  		if (ctrl->status.buf)
>  			pci_free_consistent(card->dev, STATUS_BUFFER_SIZE8,
> 

Would you like to integrate this update suggestion
into another source code repository?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/