linux-kernel - Re: [PATCH perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5591293E.80308@intel.com>
Date:	Mon, 29 Jun 2015 14:17:18 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Kan Liang <kan.liang@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE_START

On 29/06/15 14:12, Jiri Olsa wrote:
> Missing switch break since introduction of new event:
>   c4937a91ea56 perf tools: handle PERF_RECORD_LOST_SAMPLES
> 
> Cc: Kan Liang <kan.liang@...el.com>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Link: http://lkml.kernel.org/n/tip-e3gbrp2561x2s9tkqvf2wh9n@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/util/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index 4744673aff1b..a08e38339cac 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -1448,7 +1448,7 @@ int machine__process_event(struct machine *machine, union perf_event *event,
>  	case PERF_RECORD_AUX:
>  		ret = machine__process_aux_event(machine, event); break;
>  	case PERF_RECORD_ITRACE_START:
> -		ret = machine__process_itrace_start_event(machine, event);
> +		ret = machine__process_itrace_start_event(machine, event); break;
>  	case PERF_RECORD_LOST_SAMPLES:
>  		ret = machine__process_lost_samples_event(machine, event, sample); break;
>  		break;

But now you have break; break;

Isn't putting 'break' on the end of the line making things harder to read?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/