linux-kernel - Re: [PATCH] SCSI-aic94xx: Deletion of an unnecessary check before the function call "kfree"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5592908F.6060205@users.sourceforge.net>
Date:	Tue, 30 Jun 2015 14:50:23 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	"James E. J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org
CC:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] SCSI-aic94xx: Deletion of an unnecessary check before
 the function call "kfree"

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 20 Nov 2014 23:18:56 +0100
> 
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/scsi/aic94xx/aic94xx_init.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
> index c56741f..0bfdcba 100644
> --- a/drivers/scsi/aic94xx/aic94xx_init.c
> +++ b/drivers/scsi/aic94xx/aic94xx_init.c
> @@ -597,8 +597,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha)
>  	if (asd_ha->hw_prof.scb_ext)
>  		asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext);
>  
> -	if (asd_ha->hw_prof.ddb_bitmap)
> -		kfree(asd_ha->hw_prof.ddb_bitmap);
> +	kfree(asd_ha->hw_prof.ddb_bitmap);
>  	asd_ha->hw_prof.ddb_bitmap = NULL;
>  
>  	for (i = 0; i < ASD_MAX_PHYS; i++) {
> 

How are the chances to integrate this update suggestion
into another source code repository?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/