linux-kernel - Re: [PATCH] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55928DCF.9000708@users.sourceforge.net>
Date:	Tue, 30 Jun 2015 14:38:39 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Anil Gurumurthy <Anil.Gurumurthy@...gic.com>,
	"James E. J. Bottomley" <JBottomley@...allels.com>,
	Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>,
	linux-scsi <linux-scsi@...r.kernel.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] SCSI-bfa: Deletion of an unnecessary check before the
 function call "vfree"

> Patch looks good. 
> Thanks!
> Acked-by: Anil Gurumurthy <anil.gurumurthy@...gic.com>
> 
> -----Original Message-----
> From: SF Markus Elfring [mailto:elfring@...rs.sourceforge.net] 
> Sent: 21 November 2014 04:17
> To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi
> Cc: linux-kernel; kernel-janitors@...r.kernel.org; Julia Lawall
> Subject: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 20 Nov 2014 23:43:17 +0100
> 
> The vfree() function performs also input parameter validation. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/scsi/bfa/bfad_debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c index 8e83d04..a72170f 100644
> --- a/drivers/scsi/bfa/bfad_debugfs.c
> +++ b/drivers/scsi/bfa/bfad_debugfs.c
> @@ -399,8 +399,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file)
>  	if (!fw_debug)
>  		return 0;
>  
> -	if (fw_debug->debug_buffer)
> -		vfree(fw_debug->debug_buffer);
> +	vfree(fw_debug->debug_buffer);
>  
>  	file->private_data = NULL;
>  	kfree(fw_debug);
> --
> 2.1.3
> 

Would you like to integrate this update suggestion
into another source code repository?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/