linux-kernel - Re: [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFu+Ur_3ZKsRJh2hH1fzsAouNPxOvqdU_hqDUVu26U5EkDg@mail.gmail.com>
Date:	Tue, 30 Jun 2015 22:46:53 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	monstr@...str.eu,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Peter Crosthwaite <peter.crosthwaite@...inx.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Rob Herring <robherring2@...il.com>,
	Josh Cartwright <josh.cartwright@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable

On Thu, Jun 25, 2015 at 5:29 PM, Michal Simek <michal.simek@...inx.com> wrote:
> Add missing pm_runtime_disabled to remove().
>
> Error log:
> root@...qmp:~# modprobe gpio_zynq
> root@...qmp:~# lsmod
>     Not tainted
> gpio_zynq 7086 0 - Live 0xffffffbffc00a000
> root@...qmp:~# rmmod gpio_zynq
> root@...qmp:~# lsmod
>     Not tainted
> root@...qmp:~# modprobe gpio_zynq
> [  246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable!
> root@...qmp:~# rmmod gpio_zynq
> root@...qmp:~# lsmod
>     Not tainted

Yup, this was missing indeed.

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>

>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>
>  drivers/gpio/gpio-zynq.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index 2e87c4b8da26..a78882389836 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -757,6 +757,7 @@ static int zynq_gpio_remove(struct platform_device *pdev)
>         gpiochip_remove(&gpio->chip);
>         clk_disable_unprepare(gpio->clk);
>         device_set_wakeup_capable(&pdev->dev, 0);
> +       pm_runtime_disable(&pdev->dev);
>         return 0;
>  }
>
> --
> 2.3.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/