linux-kernel - Re: [PATCH 3/4] mremap: don't do uneccesary checks if new_len == old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1506301536420.24266@chino.kir.corp.google.com>
Date:	Tue, 30 Jun 2015 15:36:53 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Oleg Nesterov <oleg@...hat.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Benjamin LaHaise <bcrl@...ck.org>,
	Hugh Dickins <hughd@...gle.com>,
	Jeff Moyer <jmoyer@...hat.com>,
	Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mremap: don't do uneccesary checks if new_len ==
 old_len

On Sat, 20 Jun 2015, Oleg Nesterov wrote:

> The "new_len > old_len" branch in vma_to_resize() looks very confusing.
> It only covers the VM_DONTEXPAND/pgoff checks but everything below is
> equally unneeded if new_len == old_len.
> 
> Change this code to return if "new_len == old_len", new_len < old_len
> is not possible, otherwise the code below is wrong anyway.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/