linux-kernel - Re: [PATCH] scripts: checkpatch: ignore stable commit annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150630224231.GL20003@saruman.tx.rr.com>
Date:	Tue, 30 Jun 2015 17:42:31 -0500
From:	Felipe Balbi <balbi@...com>
To:	Joe Perches <joe@...ches.com>, Greg KH <gregkh@...uxfoundation.org>
CC:	Felipe Balbi <balbi@...com>, Andy Whitcroft <apw@...onical.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts: checkpatch: ignore stable commit annotation

On Tue, Jun 30, 2015 at 03:30:35PM -0700, Joe Perches wrote:
> On Tue, 2015-06-30 at 17:07 -0500, Felipe Balbi wrote:
> > When running scripts/checkpatch.pl on stable commits,
> > we always get the error for not using 12-character
> > commit hash abbreviation with shortlog within ("").
> 
> Looking at linux-stable v3.14.44 (randomly chosen), there
> are also commit entries like:
> 
>    This is commit 0f540c3a7cfb91c9d7a19eb0c95c24 upstream.
>  commit:  cb64edb6b89491edfdbae52ba7db9a8b8391d339 upstream
> 
> is -stable now using some script to tag these or is it
> freehanded and happens to be reasonably consistent?

afaict, Greg uses a script. Greg ?

> > Because that's actually a false positive, let's ignore
> > stable commit annotation.
> 
> This will have to be respun against another patch:
> https://lkml.org/lkml/2015/6/19/491
> 
> Please cc Andrew Morton if you resubmit.

hmmm, he doesn't get listed on get_maintainers.pl...

> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -2330,6 +2331,7 @@ sub process {
> >  			my $orig_desc = "commit description";
> >  			my $description = "";
> >  
> > +			$stable = 1 if ($line =~ /\bcommit\s+[0-9a-f]{40}\s+upstream\./i);
> 
> If these are really scripted, the case-insensitive /i
> shouldn't be necessary.

yeah, it was really just to be safer. What if Greg decides to change his
script in the future ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)