linux-kernel - Re: [PATCH] scripts: checkpatch: ignore stable commit annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150701005348.GA15251@saruman.tx.rr.com>
Date:	Tue, 30 Jun 2015 19:53:48 -0500
From:	Felipe Balbi <balbi@...com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	Felipe Balbi <balbi@...com>, Joe Perches <joe@...ches.com>,
	Andy Whitcroft <apw@...onical.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts: checkpatch: ignore stable commit annotation

On Tue, Jun 30, 2015 at 04:45:54PM -0700, Greg KH wrote:
> On Tue, Jun 30, 2015 at 05:42:31PM -0500, Felipe Balbi wrote:
> > On Tue, Jun 30, 2015 at 03:30:35PM -0700, Joe Perches wrote:
> > > On Tue, 2015-06-30 at 17:07 -0500, Felipe Balbi wrote:
> > > > When running scripts/checkpatch.pl on stable commits,
> > > > we always get the error for not using 12-character
> > > > commit hash abbreviation with shortlog within ("").
> > > 
> > > Looking at linux-stable v3.14.44 (randomly chosen), there
> > > are also commit entries like:
> > > 
> > >    This is commit 0f540c3a7cfb91c9d7a19eb0c95c24 upstream.
> > >  commit:  cb64edb6b89491edfdbae52ba7db9a8b8391d339 upstream
> > > 
> > > is -stable now using some script to tag these or is it
> > > freehanded and happens to be reasonably consistent?
> > 
> > afaict, Greg uses a script. Greg ?
> 
> I use a script, but my script didn't create both of those lines, only
> one of them, the bottom one.  The top one comes from David Miller's
> scripts which he uses when he sends me networking stable patches.
> 
> Never run checkpatch on stable commits, that makes no sense at all as I
> am pulling them directly from Linus's tree and there is nothing I can do
> to change anything in them, nor would I ever want to.
> 
> > > If these are really scripted, the case-insensitive /i
> > > shouldn't be necessary.
> > 
> > yeah, it was really just to be safer. What if Greg decides to change his
> > script in the future ?
> 
> You shouldn't care, as you shouldn't be running the script and thinking
> it matters, on stable tree commits.

fair enough, branch deleted. I had that hunch, but since there were some
complaining of checkpatch errors on stable commits, I thought about just
patching it up. Thanks for confirming.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)