linux-kernel - Re: [PATCH] f2fs:Make the function check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 30 Jun 2015 17:50:37 -0700
From:	Jaegeuk Kim <jaegeuk@...nel.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	cm224.lee@...sung.com, linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs:Make the function check_dnode have a return type of
 bool

Hi,

On Mon, Jun 29, 2015 at 04:07:01PM -0400, Nicholas Krause wrote:
> This makes the function check_dnode have a return type of bool
> due to this particular function only ever returning either one
> or zero as its return value.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  fs/f2fs/gc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index e1e7361..ebd4c6c 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -487,7 +487,7 @@ block_t start_bidx_of_node(unsigned int node_ofs, struct f2fs_inode_info *fi)
>  	return bidx * ADDRS_PER_BLOCK + ADDRS_PER_INODE(fi);
>  }
>  
> -static int check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
> +static bool check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,

Then, what about bool is_data_alive() ?

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/