lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150701065738.GA2128@gmail.com>
Date:	Wed, 1 Jul 2015 12:27:38 +0530
From:	Ravi Teja Darbha <ravi2j@...il.com>
To:	gregkh@...uxfoundation.org
Cc:	joe@...ches.com, fabio.falzoi84@...il.com,
	nizamhaider786@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH][RESEND] rts5208:Fix checkpatch warnings

else is not generally useful after a break or return, hence removed.

Signed-off-by: Ravi Teja Darbha <ravi2j@...il.com>
---
 drivers/staging/rts5208/xd.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 10fea7b..42d8d82 100644
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -1689,10 +1689,9 @@ static int xd_read_multiple_pages(struct rtsx_chip *chip, u32 phy_blk,
 			xd_set_err_code(chip, XD_TO_ERROR);
 			rtsx_trace(chip);
 			return STATUS_FAIL;
-		} else {
-			rtsx_trace(chip);
-			goto Fail;
 		}
+		rtsx_trace(chip);
+		goto Fail;
 	}
 
 	return STATUS_SUCCESS;
@@ -1905,10 +1904,9 @@ static int xd_write_multiple_pages(struct rtsx_chip *chip, u32 old_blk,
 			xd_set_err_code(chip, XD_TO_ERROR);
 			rtsx_trace(chip);
 			return STATUS_FAIL;
-		} else {
-			rtsx_trace(chip);
-			goto Fail;
 		}
+		rtsx_trace(chip);
+		goto Fail;
 	}
 
 	if (end_page == (xd_card->page_off + 1)) {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ