linux-kernel - Re: [PATCH v2 2/3] Staging: android: ion: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH6sp9P8HG6R6qYiPWDuzAErtes1anJBKS1BdgLbcJJ+rRmLTw@mail.gmail.com>
Date:	Wed, 1 Jul 2015 16:18:45 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	Sohny Thomas <sohnythomas@...o.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, arve@...roid.com,
	riandrews@...roid.com, Sumit Semwal <sumit.semwal@...aro.org>,
	carlos@...rcia.org, kernel-janitors@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] Staging: android: ion: fix coding style

On Wed, Jul 1, 2015 at 3:46 PM, Sohny Thomas <sohnythomas@...o.com> wrote:
>
> - Fixed 80 char limit exceeding line
>   and a newline after declarations as per checkpatch.pl
>
> Signed-of-by: Sohny Thomas <sohnythomas@...o.com>

You can remove the dash, and fix the -off- typo (hint: use 'git commit
-s' for automating it). Maybe hint towards what coding style is fixed
in the summary:

staging: android: ion: fix line over 80 characters

> ---
>  drivers/staging/android/ion/ion.c            | 1 +
>  drivers/staging/android/ion/ion_chunk_heap.c | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
>         struct ion_buffer *buffer;
>         struct dma_buf *dmabuf;
>         bool valid_handle;
> +
>         DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>
>         mutex_lock(&client->lock);
> diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c
> index 5474615..0813163 100644
> --- a/drivers/staging/android/ion/ion_chunk_heap.c
> +++ b/drivers/staging/android/ion/ion_chunk_heap.c
> @@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data)
>         chunk_heap->heap.ops = &chunk_heap_ops;
>         chunk_heap->heap.type = ION_HEAP_TYPE_CHUNK;
>         chunk_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE;
> -       pr_debug("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base,
> -               heap_data->size, heap_data->align);
> +       pr_debug("%s: base %lu size %zu align %ld\n", __func__,
> +               chunk_heap->base, heap_data->size, heap_data->align);
>
>         return &chunk_heap->heap;
>
> --
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/