linux-kernel - Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2015 16:21:41 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	Sohny Thomas <sohnythomas@...o.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, arve@...roid.com,
	riandrews@...roid.com, Sumit Semwal <sumit.semwal@...aro.org>,
	carlos@...rcia.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef issue

Subject suggestion: "staging: android: uapi: remove unnecessary typedef"

That makes it immediately clear what the issue is.


On Wed, Jul 1, 2015 at 3:47 PM, Sohny Thomas <sohnythomas@...o.com> wrote:
>
> As per checkpatch.pl remove unnecessary typedef
> Here ion_user_handle_t was used only in the header .
>
> Signed-of-by: Sohny Thomas <sohnythomas@...o.com>

Typo here as well.


> ---
>  drivers/staging/android/uapi/ion.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 68a14b4..9897403 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -20,7 +20,6 @@
>  #include <linux/ioctl.h>
>  #include <linux/types.h>
>
> -typedef int ion_user_handle_t;
>

I would expect an extra line to be removed here. This will leave two
empty lines.

>  /**
>   * enum ion_heap_types - list of all possible types of heaps
> @@ -88,7 +87,7 @@ struct ion_allocation_data {
>         size_t align;
>         unsigned int heap_id_mask;
>         unsigned int flags;
> -       ion_user_handle_t handle;
> +       int handle;
>  };
>
>  /**
> @@ -102,7 +101,7 @@ struct ion_allocation_data {
>   * provides the file descriptor and the kernel returns the handle.
>   */
>  struct ion_fd_data {
> -       ion_user_handle_t handle;
> +       int handle;
>         int fd;
>  };
>
> @@ -111,7 +110,7 @@ struct ion_fd_data {
>   * @handle:    a handle
>   */
>  struct ion_handle_data {
> -       ion_user_handle_t handle;
> +       int handle;
>  };
>
>  /**
> --
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/