linux-kernel - Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1435763285.12101.100.camel@perches.com>
Date:	Wed, 01 Jul 2015 08:08:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Sohny Thomas <sohnythomas@...o.com>, gregkh@...uxfoundation.org,
	arve@...roid.com, riandrews@...roid.com, sumit.semwal@...aro.org,
	carlos@...rcia.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef
 issue

On Wed, 2015-07-01 at 17:31 +0300, Dan Carpenter wrote:
> On Wed, Jul 01, 2015 at 07:17:58PM +0530, Sohny Thomas wrote:
> > 
> > As per checkpatch.pl remove unnecessary typedef
> > Here ion_user_handle_t was used only in the header .
> > 
> > Signed-of-by: Sohny Thomas <sohnythomas@...o.com>
> 
> The original code was correct.

because the typedef is exposed to user-space. (uapi)

> Checkpatch.pl is not the king of the
> world, which you must obey or die.

As Dan once said, "it's less sentient than a squirrel".

> It is just a perl script.

Don't be a squirrel.
Please engage your brain when using the stupid little tool.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/