linux-kernel - RE: [PATCH 3/3] arm: koelsch: make USB0 perform Host/Function switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SIXPR06MB0639898D241111BB3FD97160F5A80@SIXPR06MB0639.apcprd06.prod.outlook.com>
Date:	Wed, 1 Jul 2015 15:10:00 +0000
From:	Phil Edworthy <phil.edworthy@...esas.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"Kishon Vijay Abraham I" <kishon@...com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Simon Horman <horms@...ge.net.au>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>
Subject: RE: [PATCH 3/3] arm: koelsch: make USB0 perform Host/Function
 switching

Hi Sergei,

On 22 June 2015 18:49, Sergei wrote:
> Hello.
> 
> On 06/22/2015 08:43 PM, Sergei Shtylyov wrote:
> 
> >> Both USB Host (pci0) and Function (USBHS) drivers are enabled.
> >> The USB PHY driver determines which IP block should be connected
> >> based on vbus and id signals read via gpios.
> 
> >> Signed-off-by: Phil Edworthy <phil.edworthy@...esas.com>
> >> ---
> >>   arch/arm/boot/dts/r8a7791-koelsch.dts | 7 ++++---
> >>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> >> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> index cffe33f..8f394be 100644
> >> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > [...]
> >> @@ -627,13 +626,15 @@
> >>
> >>   &hsusb {
> >>       status = "okay";
> >> -    pinctrl-0 = <&usb0_pins>;
> >>       pinctrl-names = "default";
> >> -    renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
> >>   };
> >>
> >>   &usbphy {
> >>       status = "okay";
> >> +    renesas,pwr = <&gpio2 4 GPIO_ACTIVE_HIGH>;
> >> +    renesas,id = <&gpio5 31 GPIO_ACTIVE_HIGH>;
> >> +    renesas,vbus = <&gpio7 24 GPIO_ACTIVE_HIGH>;
> >> +    renesas,vbus-pwr = <&gpio7 23 GPIO_ACTIVE_HIGH>;
> 
> >     The prop names should end with "-gpio" or even "-gpios", according to the
> > GPIO bindings.
> 
>     Oh, and you didn't document the props in the previous patch.
> 
Thanks for your comments, since I've not seen any other comments I'll fix
these and repost.

Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/