linux-kernel - Re: [Resend PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55950EE7.2040405@ti.com>
Date:	Thu, 2 Jul 2015 13:13:59 +0300
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	Vitaly Andrianov <vitalya@...com>, <linus.walleij@...aro.org>,
	<gnurou@...il.com>, <linux-gpio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Sekhar Nori <nsekhar@...com>
Subject: Re: [Resend PATCH] gpio/davinci: add interrupt support for GPIOs
 16-31

On 07/01/2015 08:41 PM, Vitaly Andrianov wrote:
> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
> "binten" register (offset 8). Previous versions of GPIO only
> used bit 0, which enables GPIO 0-15 interrupts.

Cc: Sekhar Nori

>
> Signed-off-by: Vitaly Andrianov <vitalya@...com>

Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

> ---
> I posted this patch on 06/18/15 and didn't get any response.
> Please, could you review the patch.
>
>   drivers/gpio/gpio-davinci.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index c5e05c8..c90629f 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -546,6 +546,8 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
>   		chips[0].gpio_irq = bank_irq;
>   		chips[0].gpio_unbanked = pdata->gpio_unbanked;
>   		binten = BIT(0);
> +		if (pdata->gpio_unbanked > 16)
> +			binten |= BIT(1);
>
>   		/* AINTC handles mask/unmask; GPIO handles triggering */
>   		irq = bank_irq;
>


-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/