linux-kernel - Re: [PATCH v4 10/17] x86/entry/64: Really create an error-entry-from-usermode code path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150702162918.GL4001@pd.tnic>
Date:	Thu, 2 Jul 2015 18:29:19 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Rik van Riel <riel@...hat.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Kees Cook <keescook@...omium.org>,
	Brian Gerst <brgerst@...il.com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH v4 10/17] x86/entry/64: Really create an
 error-entry-from-usermode code path

On Thu, Jul 02, 2015 at 08:33:05AM -0700, Andy Lutomirski wrote:
> "Migrate error and interrupt exit work to C" puts code between those
> labels.  I could squash the patches together to make it less
> mysterious.

Nah, it is my mistake of not reviewing the whole thing first and then
sending replies. Sorry about that.

> > Also, please make all those labels local by prefixing them with .L
> > because they appear unnecesasrily in objdump output as global symbols.
> 
> Will do.

Yeah, the only maybe partly advantage of having the global labels would
be to ease debuggability but one can get to the proper offset even
without those labels so...

> I'll try to think of a good shorter name.  No promises :)

:-)

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/