linux-kernel - Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150702170407.GD30677@mtj.duckdns.org>
Date:	Thu, 2 Jul 2015 13:04:07 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	peterhuewe@....de, gregkh@...uxfoundation.org,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	Guenter Roeck <linux@...ck-us.net>, NeilBrown <neilb@...e.de>
Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj()

Hello, Jason.

On Tue, Jun 23, 2015 at 10:19:32AM -0600, Jason Gunthorpe wrote:
> The concept was to move the sysfs files to the natural location on the
> core's struct tpm.struct device and leave a symlink behind on the
> platform_device for compat.

I see.  The only problem I see is that this might get abused.  Can you
clearly mark the function that it's not intended to be used in
anything new, e.g. by renaming it to sth like
__compat_only_sysfs_link_entry_to_kobj().

> We could also just move the sysfs file and ignore the compat symlink,
> but it is not clear to me if that is an OK UAPI break for sysfs?

We shouldn't if it has actual chance of disturbing userland.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/