linux-kernel - Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55966E1E.2090409@linux.intel.com>
Date:	Fri, 03 Jul 2015 14:12:30 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Tejun Heo <tj@...nel.org>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
CC:	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	peterhuewe@....de, gregkh@...uxfoundation.org,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	Guenter Roeck <linux@...ck-us.net>, NeilBrown <neilb@...e.de>,
	"Maliszewski, Richard L" <richard.l.maliszewski@...el.com>
Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj()



On 07/02/2015 08:04 PM, Tejun Heo wrote:
 > Hello, Jason.
 >
 > On Tue, Jun 23, 2015 at 10:19:32AM -0600, Jason Gunthorpe wrote:
 >> The concept was to move the sysfs files to the natural location on the
 >> core's struct tpm.struct device and leave a symlink behind on the
 >> platform_device for compat.
 >
 > I see.  The only problem I see is that this might get abused. Can you
 > clearly mark the function that it's not intended to be used in
 > anything new, e.g. by renaming it to sth like
 > __compat_only_sysfs_link_entry_to_kobj().


Great! We will do that. Thanks for taking time and understanding what
we are dealing with. We are trying to fix all the bad behavior from TPM
subsystem and bring up to the todays standards so that next gen TPM 2.0
devices will have a solid platform.

 >> We could also just move the sysfs file and ignore the compat symlink,
 >> but it is not clear to me if that is an OK UAPI break for sysfs?
 >
 > We shouldn't if it has actual chance of disturbing userland.
 >
 > Thanks.

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/