linux-kernel - Re: Re: [RFC] arm: Add for atomic half word exchange

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 03 Jul 2015 14:35:19 +0000 (GMT)
From:	Sarbojit Ganguly <ganguly.s@...sung.com>
To:	Sarbojit Ganguly <ganguly.s@...sung.com>,
	Arnd Bergmann <arnd@...db.de>
Cc:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	SUNEEL KUMAR SURIMANI <suneel@...sung.com>,
	VIKRAM MUPPARTHI <vikram.m@...sung.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"Waiman.Long@...com" <Waiman.Long@...com>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	SHARAN ALLUR <sharan.allur@...sung.com>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>
Subject: Re: Re: [RFC] arm: Add for atomic half word exchange

Sorry about that. I dug a bit deeper and found that the code was not getting executed and rectified that. The compilation indeed fails for the lack of ldrexh instruction support on ARMv6. 

Hence, my patch needs to be guarded with !CONFIG_CPU_V6 so as to allow the code run on  >=6k and above.

I will post the v2 soon.

------- Original Message -------
Sender : Arnd Bergmann<arnd@...db.de>
Date : Jun 05, 2015 18:03 (GMT+05:30)
Title : Re: [RFC] arm: Add for atomic half word exchange

On Friday 05 June 2015 01:17:13 Sarbojit Ganguly wrote:
> Since the compilation is also a success for CONFIG_CPU_V6 with the patch,
> I think we're good to go.

I'm not following your logic. Did you create a new patch that addresses
compilation with CONFIG_CPU_V6?

The original patch should cause a compile error on v6, if it does not,
you either have a broken assembler or you forgot to enable the code
that uses these instructions. Neither of them would be a reason to
merge the patch. Please explain what is going on.

Arnd


감사합니다
사보짓   선임   삼성 전자
----------------------------------------------------------------------+
The Tao lies beyond Yin and Yang. It is silent and still as a pool of water.      |
It does not seek fame, therefore nobody knows its presence.                       |
It does not seek fortune, for it is complete within itself.                       |
It exists beyond space and time.                                                  |
----------------------------------------------------------------------+


감사합니다
사보짓   선임   삼성 전자
----------------------------------------------------------------------+
The Tao lies beyond Yin and Yang. It is silent and still as a pool of water.      |
It does not seek fame, therefore nobody knows its presence.                       |
It does not seek fortune, for it is complete within itself.                       |
It exists beyond space and time.                                                  |
----------------------------------------------------------------------+