[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <55992A6D.6010506@roeck-us.net>
Date: Sun, 05 Jul 2015 06:00:29 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Jean Delvare <jdelvare@...e.de>
CC: Constantine Shulyupin <const@...eLinux.com>, open@...e.de,
lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] hwmon: (nct7802) Add pwm control
On 07/04/2015 11:57 PM, Jean Delvare wrote:
> On Sat, 04 Jul 2015 11:08:36 -0700, Guenter Roeck wrote:
>> Hi Constantine,
>>
>> On 07/04/2015 07:57 AM, Constantine Shulyupin wrote:
>>> Added fan output control registers.
>>> Modes of operation are PWM (default) and DC.
>>>
>>
>> Another note: Since you mention DC vs. pwm mode, have you
>> considered adding pwm[123]_mode attributes to report the
>> selected mode ?
>
> If you do, please make sure these attributes are read-only.
>
They are.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists