[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150705085727.23e25d08@endymion.delvare>
Date: Sun, 5 Jul 2015 08:57:27 +0200
From: Jean Delvare <jdelvare@...e.de>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Constantine Shulyupin <const@...eLinux.com>, open@...e.de,
lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] hwmon: (nct7802) Add pwm control
On Sat, 04 Jul 2015 11:08:36 -0700, Guenter Roeck wrote:
> Hi Constantine,
>
> On 07/04/2015 07:57 AM, Constantine Shulyupin wrote:
> > Added fan output control registers.
> > Modes of operation are PWM (default) and DC.
> >
>
> Another note: Since you mention DC vs. pwm mode, have you
> considered adding pwm[123]_mode attributes to report the
> selected mode ?
If you do, please make sure these attributes are read-only.
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists