linux-kernel - Re: [PATCH] thermal: consistently use int for temperatures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20150706122640.2a61ca05@amdc2363>
Date:	Mon, 06 Jul 2015 12:26:40 +0200
From:	Lukasz Majewski <l.majewski@...sung.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.de>,
	Peter Feuerer <peter@...e.net>,
	Heiko Stuebner <heiko@...ech.de>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-acpi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Darren Hart <dvhart@...radead.org>, lm-sensors@...sensors.org
Subject: Re: [PATCH] thermal: consistently use int for temperatures

Hi Sascha,

> The thermal code uses int, long and unsigned long for temperatures
> in different places.
> 
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will
> probably immediately shut the machine down due to overtemperature if
> started below 0°C.
> 
> 'long' is 64bit on several architectures. This is not needed since
> INT_MAX °mC is above the melting point of all known materials.
> 
> Consistently use a plain 'int' for temperatures throughout the
> thermal code and the drivers. This only changes the places in the
> drivers where the temperature is passed around as pointer, when
> drivers internally use another type this is not changed.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha, thanks for this cleanup work. 

Reviewed-by: Lukasz Majewski <l.majewski@...sung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/