[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150706181814.GB40907@vmdeb7>
Date: Mon, 6 Jul 2015 11:18:14 -0700
From: Darren Hart <dvhart@...radead.org>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
Eduardo Valentin <edubezval@...il.com>,
linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.de>,
Peter Feuerer <peter@...e.net>,
Heiko Stuebner <heiko@...ech.de>,
Lukasz Majewski <l.majewski@...sung.com>,
Stephen Warren <swarren@...dotorg.org>,
Thierry Reding <thierry.reding@...il.com>,
linux-acpi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
linux-samsung-soc@...r.kernel.org,
Guenter Roeck <linux@...ck-us.net>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Maxime Ripard <maxime.ripard@...e-electrons.com>,
lm-sensors@...sensors.org
Subject: Re: [PATCH] thermal: consistently use int for temperatures
On Mon, Jul 06, 2015 at 09:19:49AM +0200, Sascha Hauer wrote:
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0°C.
>
> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
> is above the melting point of all known materials.
>
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
...
> drivers/platform/x86/acerhdf.c | 9 ++++----
> drivers/platform/x86/intel_mid_thermal.c | 9 ++++----
For these two:
Reviewed-by: Darren Hart <dvhart@...ux.intel.com>
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists