linux-kernel - Re: [RFC V2 PATCH 1/4] perf: Add PERF_RECORD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150706111748.GB3644@twins.programming.kicks-ass.net>
Date:	Mon, 6 Jul 2015 13:17:48 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Andi Kleen <ak@...ux.intel.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Jiri Olsa <jolsa@...hat.com>,
	Stephane Eranian <eranian@...gle.com>,
	mathieu.poirier@...aro.org, Pawel Moll <pawel.moll@....com>
Subject: Re: [RFC V2 PATCH 1/4] perf: Add PERF_RECORD_SWITCH to indicate
 context switches

On Fri, Jul 03, 2015 at 03:52:39PM +0300, Adrian Hunter wrote:
> +static void perf_event_switch(struct task_struct *task,
> +			      struct task_struct *next_prev, bool out)
> +{

The patch looks good, however with perf_pmu_sched_task() we have bool
sched_in, and here we have bool out.

Maybe make that consistent?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/