linux-kernel - Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150706111952.GC16864@breakpoint.cc>
Date:	Mon, 6 Jul 2015 13:19:53 +0200
From:	Florian Westphal <fw@...len.de>
To:	Julien Grall <julien.grall@...rix.com>
Cc:	Florian Westphal <fw@...len.de>, stephen@...workplumber.org,
	davem@...emloft.net, bridge@...ts.linux-foundation.org,
	netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
	linux-kernel@...r.kernel.org,
	Bernhard Thaler <bernhard.thaler@...et.at>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	ian.campbell@...rix.com, wei.liu2@...rix.com
Subject: Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

Julien Grall <julien.grall@...rix.com> wrote:
> On 03/07/15 21:42, Florian Westphal wrote:
> > I think it makes more sense to use __in6_dev_get() instead which doesn't
> > take a reference.
> 
> __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on
> this code is very limited. Are we sure that one this lock is hold? At
> first glance, I wasn't able to find one.

All netfilter hooks are rcu_read_locked via nf_hook_slow().

BTW, netfilter patches should be sent to netfilter-devel@...r.kernel.org.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/