linux-kernel - Re: [PATCH] perf probe: Delete an unnecessary check before the function call "strfilter_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559A696C.4030704@hitachi.com>
Date:	Mon, 06 Jul 2015 20:41:32 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] perf probe: Delete an unnecessary check before the
 function call "strfilter__delete"

On 2015/07/04 14:54, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 4 Jul 2015 07:44:22 +0200
> 
> The strfilter__delete() function tests whether its argument is NULL and
> then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 

This looks OK for me.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  tools/perf/builtin-probe.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index 1272559..b81cec3 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -297,8 +297,7 @@ static void cleanup_params(void)
>  		clear_perf_probe_event(params.events + i);
>  	line_range__clear(&params.line_range);
>  	free(params.target);
> -	if (params.filter)
> -		strfilter__delete(params.filter);
> +	strfilter__delete(params.filter);
>  	memset(&params, 0, sizeof(params));
>  }
>  
> 


-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/