linux-kernel - [tip:perf/core] perf probe: Delete an unnecessary check before the function call "strfilter_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-200802a4a79b3a7a1cf924ad870d3265023d0787@git.kernel.org>
Date:	Mon, 6 Jul 2015 09:33:14 -0700
From:	tip-bot for Markus Elfring <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	acme@...hat.com, mingo@...nel.org, tglx@...utronix.de,
	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
	masami.hiramatsu.pt@...achi.com, elfring@...rs.sourceforge.net,
	julia.lawall@...6.fr, hpa@...or.com
Subject: [tip:perf/core] perf probe:
  Delete an unnecessary check before the function call "strfilter__delete"

Commit-ID:  200802a4a79b3a7a1cf924ad870d3265023d0787
Gitweb:     http://git.kernel.org/tip/200802a4a79b3a7a1cf924ad870d3265023d0787
Author:     Markus Elfring <elfring@...rs.sourceforge.net>
AuthorDate: Sat, 4 Jul 2015 07:44:22 +0200
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Mon, 6 Jul 2015 08:58:36 -0300

perf probe: Delete an unnecessary check before the function call "strfilter__delete"

The strfilter__delete() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc: Julia Lawall <julia.lawall@...6.fr>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: kernel-janitors@...r.kernel.org
Link: http://lkml.kernel.org/r/5597751A.5000506@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/builtin-probe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 1272559..b81cec3 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -297,8 +297,7 @@ static void cleanup_params(void)
 		clear_perf_probe_event(params.events + i);
 	line_range__clear(&params.line_range);
 	free(params.target);
-	if (params.filter)
-		strfilter__delete(params.filter);
+	strfilter__delete(params.filter);
 	memset(&params, 0, sizeof(params));
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/