linux-kernel - RE: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A0337AB55C80C@SW-EX-MBX01.diasemi.com>
Date:	Mon, 6 Jul 2015 14:23:07 +0000
From:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
To:	Lee Jones <lee.jones@...aro.org>,
	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge
 support

On July 3, 2015 16:19, Lee Jones wrote:

> > @@ -22,6 +23,7 @@ Required properties:
> >  Sub-devices:
> >  - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150-
> gpadc.txt
> >  - da9150-charger: See Documentation/devicetree/bindings/power/da9150-
> charger.txt
> > +- da9150-fg: See Documentation/devicetree/bindings/power/da9150-fg.txt
> 
> Can you send a subsequent patch doing:
> 
> s-Documentation/devicetree/bindings/-../-

Yep, can do.

> >
> >
> 
> Superfluous '\n' here.

Will remove.

> 
> >  Example:
> > @@ -40,4 +42,8 @@ Example:
> >  		da9150-charger {
> >  			...
> >  		};
> > +
> > +		da9150-fg {
> > +			...
> > +		};
> 
> Perhaps a little content wouldn't go amiss here for quick reference.
> 
> Saves dipping in and out of the other binding files.
> 
> This patch is fine though:
>   Acked-by: Lee Jones <lee.jones@...aro.org>
> 

Thanks for the ack. Will add a little info in the example.