linux-kernel - [PATCH] vme: print unhandled VME access errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1436193835-20154-1-git-send-email-dmitry.kalinkin@gmail.com>
Date:	Mon,  6 Jul 2015 17:43:55 +0300
From:	Dmitry Kalinkin <dmitry.kalinkin@...il.com>
To:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Cc:	Martyn Welch <martyn.welch@...com>,
	Manohar Vanga <manohar.vanga@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Kalinkin <dmitry.kalinkin@...il.com>
Subject: [PATCH] vme: print unhandled VME access errors

This will enable error messages for accesses done through mmap.

Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@...il.com>
---
This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset.
---
 drivers/vme/vme.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 7a10d92..72924b0 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -1028,6 +1028,7 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
 {
 	struct list_head *handler_pos = NULL;
 	struct vme_error_handler *handler;
+	int handler_triggered = 0;
 	u32 aspace = vme_get_aspace(am);
 
 	list_for_each(handler_pos, &bridge->vme_error_handlers) {
@@ -1040,8 +1041,14 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
 				handler->first_error = address;
 			if (handler->num_errors != UINT_MAX)
 				handler->num_errors++;
+			handler_triggered = 1;
 		}
 	}
+
+	if (!handler_triggered)
+		dev_err(bridge->parent,
+			"Unhandled VME access error at address 0x%llx\n",
+			address);
 }
 EXPORT_SYMBOL(vme_bus_error_handler);
 
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/