linux-kernel - Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 00:44:29 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Chen Gang <xili_gchen_5257@...mail.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Simon Horman <horms+renesas@...ge.net.au>, <cj@...ux.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Mikael Starvik <starvik@...s.com>,
	driverdevel <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on
 CLKDEV_LOOKUP

Hi Paul,

On Mon, 6 Jul 2015 09:42:47 -0400 Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
>
> [Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:
> 
> > On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > >
> > > On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@...mail.com> wrote:
> > > > It needs clk_add_alias() from clk drivers, which is implemented in
> > > > "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
> > > >
> > > > Normally, archs and clk driver its own will decide whether select
> > > > CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
> > > >
> > > > The related error (with allmodconfig under cris for next-20150702):
> > > >
> > > >   drivers/built-in.o: In function `board_staging_register_clock':
> > > >   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
> > > >
> > > >
> > > > Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> > > 
> > > Fix available for the last 15 days:
> > > 
> > > https://lkml.org/lkml/2015/6/20/215
> > 
> > I added Chen's patch to my fixes tree today (only because I couldn't
> > easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a
> > full mail message from lkml.org?  Or Geert, maybe that is not the best
> > place to link to.
> 
> I have had reasonable success pulling stuff out of lkml patchworks:
> 
> https://patchwork.kernel.org/patch/6651831/
> 
> BTW, Chen's patch is missing the OF_IRQ dependency Geert found in
> his build coverage; I'd folded that into the v2 above, figuring
> that is what he'd desired I do with it.

I have replaced Chen's patch with your patch in my fixes tree ...
hopefully it won;t need to be there long.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped