linux-kernel - Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150706170746.GA8021@saruman.tx.rr.com>
Date:	Mon, 6 Jul 2015 12:07:46 -0500
From:	Felipe Balbi <balbi@...com>
To:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>
CC:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent
 to DEPCMD register fails

On Wed, Jul 01, 2015 at 07:29:28AM +0000, Subbaraya Sundeep Bhatta wrote:
> Hi Felipe,
> 
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbi@...com]
> > Sent: Tuesday, June 30, 2015 3:17 AM
> > To: Subbaraya Sundeep Bhatta
> > Cc: balbi@...com; gregkh@...uxfoundation.org; linux-usb@...r.kernel.org;
> > linux-kernel@...r.kernel.org; stable@...r.kernel.org; Subbaraya Sundeep
> > Bhatta
> > Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command
> > sent to DEPCMD register fails
> > 
> > Hi,
> > 
> > On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta
> > wrote:
> > > We need to return error to caller if command is not sent to controller
> > > succesfully.
> > >
> > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
> > > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> > > Cc: <stable@...r.kernel.org>
> > > ---
> > > v2 changes:
> > > 	Added Fixes and Cc in commit message.
> > 
> > I noticed that this breaks at least my AM437x silicon with DWC3 2.40a
> > when used with g_zero and testusb. As of now, it could be that silicon is
> > mis-behaving because I got a Transfer Complete before the failing Set
> > Endpoint Transfer Resource command.
> > 
> > In any case, can you run on your setup with g_zero and test.sh/testusb
> > [1]/[2] just to verify that it really works for you ?
> 
> Ok I will do that.

Did you manage to run the test I asked ? If we don't get down to this,
I'll have to revert your patch as it regresses my platforms.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)