linux-kernel - Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 02:10:26 +0000
From:	John Youn <John.Youn@...opsys.com>
To:	"balbi@...com" <balbi@...com>, John Youn <John.Youn@...opsys.com>
CC:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent
 to DEPCMD register fails

On 7/1/2015 8:00 PM, Felipe Balbi wrote:
> On Thu, Jul 02, 2015 at 02:03:14AM +0000, John Youn wrote:
>> On 6/29/2015 2:48 PM, Felipe Balbi wrote:
>>> Hi again,
>>>
>>> On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
>>>> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
>>>>> We need to return error to caller if command is not sent to
>>>>> controller succesfully.
>>>>>
>>>>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
>>>>> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
>>>>> Cc: <stable@...r.kernel.org>
>>>>> ---
>>>>> v2 changes:
>>>>> 	Added Fixes and Cc in commit message.
>>>>
>>>> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a
>>>> when used with g_zero and testusb. As of now, it could be that silicon
>>>> is mis-behaving because I got a Transfer Complete before the failing Set
>>>> Endpoint Transfer Resource command.
>>>>
>>>> In any case, can you run on your setup with g_zero and test.sh/testusb
>>>> [1]/[2] just to verify that it really works for you ?
>>>>
>>>> Meanwhile, I'll continue testing on my end.
>>>>
>>>> cheers
>>>>
>>>> [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c
>>>> [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh
>>>
>>> Adding John here. John, any chance you could fire up dwc3 on HAPS and
>>> see wether it works or fails for you ?
>>>
>>> cheers
>>>
>>
>> Hi Felipe,
>>
>> Just an update on this.
>>
>> I'm trying to get this working with our latest IP with dwc3 from your
>> testing/next branch. It fails the usbtest with a problem unrelated to
>> this patch.
>>
>> It passes on 4.1.1.
>>
>> I'll have to look into the failure but I won't get to it until next
>> week as I'm off the rest of this week.
> 
> interesting... If you could post failure signature, I can help looking
> at it, but I guess it's too late to ask :-)
> 
> thanks for helping though
> 


Hi Felipe,

Nevermind about my issue, it ended up being a setup-related
problem.

I actually do see the same error as you due to this series of
patches. Except I see it happening before even the first
iteration. I get a completion status of 1 for the Set Endpoint
Transfer Resources command. I'm not sure why this is.

I don't see any conflict with any previous Transfer Complete.

I will have to consult with some hardware engineers tomorrow to
look into it further.

The trace is attached.

John




View attachment "dwc3-trace.txt" of type "text/plain" (52315 bytes)