lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Jul 2015 19:15:34 +0200 From: Boris Brezillon <boris.brezillon@...e-electrons.com> To: Stephen Boyd <sboyd@...eaurora.org> Cc: Mike Turquette <mturquette@...aro.org>, linux-clk@...r.kernel.org, Mikko Perttunen <mikko.perttunen@...si.fi>, Tomeu Vizoso <tomeu.vizoso@...labora.com>, Jonathan Corbet <corbet@....net>, Tony Lindgren <tony@...mide.com>, Ralf Baechle <ralf@...ux-mips.org>, Emilio L??pez <emilio@...pez.com.ar>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Tero Kristo <t-kristo@...com>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org, linux-mips@...ux-mips.org Subject: Re: [PATCH v3] clk: change clk_ops' ->determine_rate() prototype On Wed, 3 Jun 2015 16:37:28 -0700 Stephen Boyd <sboyd@...eaurora.org> wrote: > On 05/20, Boris Brezillon wrote: > > Clock rates are stored in an unsigned long field, but ->determine_rate() > > (which returns a rounded rate from a requested one) returns a long > > value (errors are reported using negative error codes), which can lead > > to long overflow if the clock rate exceed 2Ghz. > > > > Change ->determine_rate() prototype to return 0 or an error code, and pass > > a pointer to a clk_rate_request structure containing the expected target > > rate and the rate constraints imposed by clk users. > > > > The clk_rate_request structure might be extended in the future to contain > > other kind of constraints like the rounding policy, the maximum clock > > inaccuracy or other things that are not yet supported by the CCF > > (power consumption constraints ?). > > > > Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com> > > > > CC: Jonathan Corbet <corbet@....net> > > CC: Tony Lindgren <tony@...mide.com> > > CC: Ralf Baechle <ralf@...ux-mips.org> > > CC: "Emilio López" <emilio@...pez.com.ar> > > CC: Maxime Ripard <maxime.ripard@...e-electrons.com> > > CC: Tero Kristo <t-kristo@...com> > > CC: linux-doc@...r.kernel.org > > CC: linux-kernel@...r.kernel.org > > CC: linux-arm-kernel@...ts.infradead.org > > CC: linux-omap@...r.kernel.org > > CC: linux-mips@...ux-mips.org > > --- > > > > Hi Stephen, > > > > This patch is based on clk-next and contains the changes you suggested > > in your previous review. > > > > It was tested on sama5d4 and compile tested on several ARM platforms > > (those enabled in multi_v7_defconfig). > > > > Thanks. I think we should wait until the next -rc1 drops to apply the > patch for the next merge window. That will make it least likely to conflict > with other trees, and we can provide it on a stable branch should there > be clock providers going through other trees somewhere. Please > remind me if I forget. Just sent a v4 fixing the bug you reported and rebasing my work on 4.2-rc1. > > > @@ -1186,15 +1191,21 @@ EXPORT_SYMBOL_GPL(__clk_determine_rate); > > */ > > unsigned long __clk_round_rate(struct clk *clk, unsigned long rate) > > { > > - unsigned long min_rate; > > - unsigned long max_rate; > > + > > + struct clk_rate_request req; > > + int ret; > > > > if (!clk) > > return 0; > > > > - clk_core_get_boundaries(clk->core, &min_rate, &max_rate); > > + clk_core_get_boundaries(clk->core, &req.min_rate, &req.max_rate); > > + req.rate = rate; > > + > > + ret = clk_core_round_rate_nolock(clk->core, &req); > > + if (ret) > > + return ret; > > This returns a negative int for unsigned long. Is that intentional? > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists