linux-kernel - Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jul 2015 15:43:28 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Alex Hung <alex.hung@...onical.com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Corentin Chary <corentin.chary@...il.com>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	acpi4asus-user@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for
 Windows 8

On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote:
> ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and
> HP are doing it.  It is just ASUS who decides LED should be controlled
> by software unlike HP whose LED is driven by hardware pins on mini
> card.

Alex, please refrain from top posting on Linux kernel mailing lists, it breaks
the established practice the readers are setup for.

Regarding the ATK4001 device, it did sound like it did more than control the
radios and the associcated LED. If that is all it does, then asus-rbtn is fine.
If it does something beyond that, we need understand what that is, as a more
platform-centric name would be more appropriate.

Thanks,

> 
> On Fri, Jul 3, 2015 at 3:25 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> > On Thursday 02 July 2015 15:10:39 Alex Hung wrote:
> >> Thanks for the support.  I will create v3 based with LED triggers.
> >>
> >> Just for information.  ASUS's wording is as below:
> >>
> >> Fn+F2 can be used to turn on or off all radio capabilities in the
> >> device (as known as airplane mode switch).  I don't have any
> >> preferences on the name.  We may use the term airplane-mode do if
> >> asus-rbtn is not preferred.  Let me know if there are any suggestions.
> >>
> >
> > This is OK, but I though that ACPI ATK4001 device is some
> > multifunctional device, which is doing more then LED control... (At
> > least I understand it from your comments). So in this case I would not
> > call driver led/radio related. Right?
> >
> >>
> >> On Wed, Jul 1, 2015 at 7:48 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> >> > On Wednesday 01 July 2015 00:09:41 Alex Hung wrote:
> >> >> ATK4001 is an independent ACPI device, and Method(HSWC) is its method
> >> >> to control LED (actually it has other functions but only LED is needed
> >> >> so far).
> >> >
> >> > If this driver is for supporting ACPI ATK4001 device (which has couple
> >> > of methods, not only LED) it is really good idea to name it asus-rbtn?
> >> >
> >> > Darren, you as maintainer of platform drivers, what do you think? I
> >> > believe in future this driver will be extended to support more functions
> >> > and so name asus-rbtn will be confusing.
> >> >
> >> > --
> >> > Pali Rohár
> >> > pali.rohar@...il.com
> >>
> >
> > --
> > Pali Rohár
> > pali.rohar@...il.com
> 
> 
> 
> -- 
> Cheers,
> Alex Hung
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/