| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <1436338607-43389-1-git-send-email-maninder1.s@samsung.com> Date: Wed, 08 Jul 2015 12:26:47 +0530 From: Maninder Singh <maninder1.s@...sung.com> To: a.zummo@...ertech.it, alexandre.belloni@...e-electrons.com, rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org Cc: pankaj.m@...sung.com, Maninder Singh <maninder1.s@...sung.com> Subject: [PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check removing below static analysis error:- (error) Possible null pointer dereference: client if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) ^^^^^^^ Error comes beacause client is dereferenced before NULL check. So probabily NULL this check is not required. Signed-off-by: Maninder Singh <maninder1.s@...sung.com> --- drivers/rtc/rtc-bq32k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 92679df..409de9f 100644 --- a/drivers/rtc/rtc-bq32k.c +++ b/drivers/rtc/rtc-bq32k.c @@ -212,7 +212,7 @@ static int bq32k_probe(struct i2c_client *client, if (error) return error; - if (client && client->dev.of_node) + if (client->dev.of_node) trickle_charger_of_init(dev, client->dev.of_node); rtc = devm_rtc_device_register(&client->dev, bq32k_driver.driver.name, -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists